Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change check for compressed reports to look through all exception codes #186

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

richardhallett
Copy link
Contributor

Looking at first exception code doesn't always work if there are multiple exception codes, order is variable.

Purpose

Prevents certain compressed usage reports from being processed.

Related to: datacite/datacite#2200

Approach

Fixes it

Open Questions and Pre-Merge TODOs

N/A

Learning

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

Looking at first doesn't always work if there are multiple, order is variable.
@richardhallett richardhallett merged commit c3c31b2 into master Sep 16, 2024
2 checks passed
@richardhallett richardhallett deleted the fix_compressed_check branch September 16, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants